Unit test paths appear to break on Windows

OttoStruve / muler

A Python package for working with pipeline-produced spectra from IGRINS, HPF, and Keck NIRSPEC

https://muler.readthedocs.io

MIT License

15 stars 9 forks source link

Unit test paths appear to break on Windows #113

Open Sujay-Shankar opened 2 years ago

Sujay-Shankar commented 2 years ago

local_files = glob.glob("**/SDCH*.spec_a0v.fits", recursive=True)
file = local_files[0]

^ throws an index error

gully commented 2 years ago

We should use either pathlib or os.path... to make these paths platform independent.

I suspect the same problem may true in other places, where we assume Unix-like paths... Let's scan through both muler and gollum for this assumption. Also, I wonder if it's worth setting up a Continuous Integration GitHub Actions matrix on Windows...