search

OttoStruve / muler

A Python package for working with pipeline-produced spectra from IGRINS, HPF, and Keck NIRSPEC
https://muler.readthedocs.io
MIT License
14 stars 9 forks source link

Remove annoying warning notice about missing meta data which was disp… #134

Closed kfkaplan closed 1 year ago

kfkaplan commented 1 year ago

…laying at the incorrect time.

This removes the annoying missing metadata warning which displays every time you modify an IGRINS spectrum list object in muler. See issue: https://github.com/OttoStruve/muler/issues/133

gully commented 1 year ago

Thanks @kfkaplan ! This looks good to me.

We could and should use different tiers of logging. For example there's log.info and log.warn. Users can then opt-into different granulaties by setting a single flag. I think the default is to print warnings but not infos

kfkaplan commented 1 year ago

Hmm I agree. I think in this specific case, this IS a warning that should display but it is firing at the wrong time. I'm not sure the best time to check if the meta data does not exist. If you know where that should be, we should move this warning there. Otherwise if there really is no reason to check, we can delete this warning completely. For now I've just commented it out.