search

OttoStruve / muler

A Python package for working with pipeline-produced spectra from IGRINS, HPF, and Keck NIRSPEC
https://muler.readthedocs.io
MIT License
15 stars 9 forks source link

Support an IGRINSSlit class #145

Open gully opened 1 year ago

gully commented 1 year ago

In PR #136 I pitched the prospect for an IGRINSSlit class, and provided a sketch of what methods could reside there. I think this is a good idea, and we should talk about it. Currently housing all those functions on top of IGRINSSpectrum objects seems out-of-place, since most of those functions are operating on a distinct data product.

I think this devoted IGRINSSlit class would also alleviate the tension we felt in #138.

kfkaplan commented 1 year ago

This is a good idea. I think it should be generalized so muler can use it for other slit spectrometers. I've built a Slit class and put it in utilities.py. Not sure if this is the best place for it, but it works for now. You can see what I've done in PR https://github.com/OttoStruve/muler/pull/136.

gully commented 1 year ago

Nice! I think the best path forward is to pair-code on this. We should move it from utilities.py to either a standalone slit.py or scene.py.