search

Ottodix / Eole-foobar-theme

Eole blows gently into your ear his nicest melodies.
1.33k stars 87 forks source link

SMP error #100

Closed 1024mb closed 4 years ago

1024mb commented 4 years ago

I just got an error message when launching foobar2000. What I did was: Images where not loading (album view/tab was active) so I switched to Playlist tab and got the error.

Error: Spider Monkey Panel v1.3.1 (CoverPanel v1.2.3b18 by Ottodix)
g_image_cache.resetCache is not a function

File: JStheme_common.js
Line: 3153, Column: 17

Stack trace:
  freeCacheMemory@JStheme_common.js:3153:17
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:708:27
  oCover/this.on_item_focus_change@WSHnowplaying.js:664:9
  on_notify_data@WSHnowplaying.js:1018:13
  oBrowser/this.on_mouse@WSHsmoothplaylist_trackinfos.js:3487:16
  on_mouse_lbtn_down@WSHsmoothplaylist_trackinfos.js:5098:15

After reopening foobar2k it loaded everything correctly. I'm using latest files downloaded from the repo 20 minutes ago. I'm using Spider Monkey Panel 1.3.1.

Ottodix commented 4 years ago

Fixed, thanks for reporting

1024mb commented 4 years ago

Hey, thank you for all your work.

1024mb commented 4 years ago

@Ottodix I have just tested the updated theme and now foobar2k doesn't show me any error but now the theme doesn't respond. The same is happening as before, album pictures are not loading/showing but now as soon as I click on something else the whole window stops responding to anything, it doesn't dim itself as non responding windows normally do but it makes that common sound when something doesn't respond when I click anywhere on the window. I can manage foobar from within the tray icon so I can exit the program but I can't play anything nor interact with the theme.

While it's not responding is also using CPU but as soon as I exit foobar2k from the tray icon and start it again it now shows all images and works normally but then if I close foobar2000 and then open it the theme stops responding again and I have to exit from the tray and start the program for the theme to work normally. It seems to work intermittently. Sometimes I have to close it once, other times I have to close it twice (open, close, open, close, open and now it works normally).
I haven't found any crash report because it doesn't crash so I don't know what more to report. It may be because I have chosen "Load all covers at startup" and I have 2k albums? But then foobar isn't using much RAM either way, max it has got is 600Mb, right now is sit at 346.54Mb and 2k albums isn't a immense number so its weird that no one else has reported this.

Ottodix commented 4 years ago

And the thumbnail max with setting? You didn't put an enormous number there? And your cache is fully formed, ie: all covers are displayed without delay, when it works?

1024mb commented 4 years ago

Thumbnails max width is at 500px, should I try to lower that?
Now that you say that I have tried scrolling the list with the mouse wheel and it takes a couple seconds for the image to show up, if I scroll manually to -lets say the middle of the album list- it takes even more time to load the images and foobar RAM usage has increased to 463.37Mb so I assume it isn't storing all the images on the cache?

Btw, this issue (the theme no responding) has started recently, iirc it started when I updated some foobar components, Spider Monkey Panel being one of them but I don't remember which one was the other, here is a list of all the components I have installed and their versions:

2020-08-28_14-48-08

Ottodix commented 4 years ago

You've got quite a lot of component... but i don't think it's related. A couple of second, it means that your cache isn't fully formed yet. Probably that when all images will be stored in the cache, your issue will goes away. Of course, it's not supposed to freeze during the cache creation. I tried to fix that already, without success yet, it seems. On my config it work fine, but from time to time, there is always a guy who post an issue there related to memory and the cache system

Yes, decreasing this thumbnails max width will help, but 500px isn't that much.

1024mb commented 4 years ago

I just got a crash. Every panel has crashed and this is what I got:

Error: Spider Monkey Panel v1.3.1 (CoverPanel v1.2.3b18 by Ottodix)
Out of memory: 2816467/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (CoverPanel v1.2.3b18 by Ottodix)
Out of memory: 2816467/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (TitleBar v1.2.3b18 by Ottodix)
Out of memory: 1171187/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (CoverPanel v1.2.3b18 by Ottodix)
Out of memory: 2029827/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (LibraryFilter v1.2.3b18 by Ottodix)
Out of memory: 15222989/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (PlaylistHeader v1.2.3b18 by Ottodix)
Out of memory: 1140611/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (BottomPlaylist v1.2.3b18 by Ottodix)
Out of memory: 215173819/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (BottomPlaylist v1.2.3b18 by Ottodix)
Out of memory: 215173819/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (PlaylistFilter3 v1.2.3b18 by Ottodix)
Out of memory: 13498909/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (GraphicBrowser v1.2.3b18 by Ottodix)
Out of memory: 259968110/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (LibraryTree v1.2.3b18 by Ottodix)
Out of memory: 1389823/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (PlaylistFilter1 v1.2.3b18 by Ottodix)
Out of memory: 2762829/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (LyricsTitle v1.2.3b18 by Ottodix)
Out of memory: 1105263/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (Controls v1.2.3b18 by Ottodix)
Out of memory: 1837543/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (SmoothPlaylistManager v1.2.3b18 by Ottodix)
Out of memory: 2582209/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (NowPlayingPlaylist v1.2.3b18 by Ottodix)
Out of memory: 522689950/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (ArtistBio v1.2.3b18 by Ottodix)
Out of memory: 6246963/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (GraphicBrowser v1.2.3b18 by Ottodix)
Out of memory: 2457718/1073741824 bytes

Error: Spider Monkey Panel v1.3.1 (PlaylistFilter2 v1.2.3b18 by Ottodix)
Out of memory: 2889885/1073741824 bytes

Every message was in a different error window. Also I got a message about a busy script and after that I got these errors:

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({2E1B4B61-F126-4FCE-8C13-B9FE02F2E295})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:711:27
  on_playback_new_track@WSHnowplaying.js:476:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({2E1B4B61-F126-4FCE-8C13-B9FE02F2E295})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:711:27
  on_playback_new_track@WSHnowplaying.js:476:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({2E1B4B61-F126-4FCE-8C13-B9FE02F2E295})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:711:27
  on_playback_new_track@WSHnowplaying.js:476:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({2E1B4B61-F126-4FCE-8C13-B9FE02F2E295})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:711:27
  on_playback_new_track@WSHnowplaying.js:476:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({2E1B4B61-F126-4FCE-8C13-B9FE02F2E295})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:711:27
  on_playback_new_track@WSHnowplaying.js:476:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({A03C1E7D-4D34-4D41-8CDA-19EDDBA2626E})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHcoverpanel.js:476:5
  oCover/this.getArtwork@WSHcoverpanel.js:528:27
  on_playback_new_track@WSHcoverpanel.js:623:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

Error: Spider Monkey Panel v1.3.1 ({2E1B4B61-F126-4FCE-8C13-B9FE02F2E295})
brw is not defined

File: JStheme_common.js
Line: 3154, Column: 3

Stack trace:
  freeCacheMemory@JStheme_common.js:3154:3
  get_albumArt_async@JStheme_common.js:3042:3
  oImageCache/this.hit@WSHnowplaying.js:573:11
  oCover/this.getArtwork@WSHnowplaying.js:711:27
  on_playback_new_track@WSHnowplaying.js:476:11
  on_focus@WSHsmoothplaylist_trackinfos.js:6541:1
  on_mouse_rbtn_down@WSHgraphicbrowser_trackinfos.js:6620:25

If I right click and reload every panel it all works again.

Ottodix commented 4 years ago

Yes, there is no doubt about the kind of issue you've got. Try to decrease the thumbnail max width, and set the memory settings to 0 - Mimimum.

I would really like to avoid completely those errors. So far, I didn't find the right solution

Ottodix commented 4 years ago

I did a little change which may help. Nothing drastically new though, it will simply reduce a little bit the occuring of such errors, but it won't avoid them completely You can grab it there, you just need to replace the existing files, you don't need to import again the .fcl file https://github.com/Ottodix/Eole-foobar-theme/zipball/master/

1024mb commented 4 years ago

Thank you, I've tested this for two days already and so far no errors, hopefully it will continue like that though I also can just choose "Keep loaded covers in memory" to mitigate these problems, is not such a user experience killer.

Thanks for all your work, your theme is amazing.