Ottodix / Eole-foobar-theme

Eole blows gently into your ear his nicest melodies.
1.37k stars 87 forks source link

Library view and filter issue #111

Closed kagamihamai closed 4 years ago

kagamihamai commented 4 years ago

Hello,

By default the 3 tab of the library are genre, artist, album, I want it to display album artists rather than genres, so at first I clicked setting and went to "group by" and edit the title format and yes it worked. But then I found that when mouse hover on the album artist tab the tooltip still says "genre filter", and search box below also says genres. I edited line 979 in WSHfilter.js so the tooltip now says album artist filter while the search box still shows how many "genres" I have.

This issue also occurs in the playlist page, I edited line 825 in WSHfilter.js so the 1st filter box shows "Album Artists..." in the right yet it still shows "1 genre" in the left.

Another issue is that, when clicking library tree in the library page, things sort of glitch out for some reason? 3 tabs change from album artist, artist, album to genre, artist, album artist once I switch to library tree view, and if I click that "genre" tab it goes to album artists, click "album artist" tab it goes to albums.

I do not understand javascript at all, so there's little for me to do in order to customize it as I wish to (I tired my best), I would like to know how to do it properly.

And most importantly, thank you for your amazing work!

Ottodix commented 4 years ago

Yep, those issues have been fixed there https://github.com/Ottodix/Eole-foobar-theme/zipball/master/

Thanks for reporting!

Ottodix commented 4 years ago

You may have to reset the ALBUM filter (preset 3). Try to edit this preset, put any custom value, validate and then reset it by click preset 3 > Default (%album%). (in order to fix this issue with the library tree showing the wrong labels)

kagamihamai commented 4 years ago

After doing the aforementioned operation, the ALBUM filter now displays correctly when in library tree view, whereas ABM.ARTIST filter is still displayed as GENRE.

kagamihamai commented 4 years ago

Oh it's correct now after restarting foobar2000.