Ottodix / Eole-foobar-theme

Eole blows gently into your ear his nicest melodies.
1.38k stars 87 forks source link

Album image cache #200

Closed krosbonz closed 2 years ago

krosbonz commented 2 years ago

Something seems odd with the album image caching to the "eole-img-cache" directory.

If I empty that folder and play a bunch of music, I can see a new image being added for each new artist/album. It appears to cache a high res image the first time a unique song from an album is played, but the next time another song from the same album plays the image associated with the song under "Now Playing" is a lower res image.

I have no other images in the album folders other than the high res image and I embed the same image when I tag.

So... 1) Can you tell me how to disable imaging caching? I don't care about performance I just want to have high res images for each song.

2) Please let me know, based on my explanation, how to fix the problem.

Thank you

Ottodix commented 2 years ago

Foobar > skin settings > Covers & memory usage. In this settings window, you'll be able to increase the image cache resolution. A too high value may crash your foobar or make it use a looot of memory. You can't completely disable the image cache thought (I could add this as an option, but well, in my opinion it would make the skin unusable).

krosbonz commented 2 years ago

Thanks for the quick reply. I will increase the minimum px size and see if that helps.

To be thorough I just want to make sure I properly explained what I see happening. Example: Empty cache folder. Play the first song from an album. Image shows up in cache folder. Album image shown is high res. Whenever any other song from that album with a cached album image is played, the image is low res. If I look at the images in the cache folder, it doesn't appear the image for the album updates or gets replaced (based on modification date). I can right click the image and select "Refresh this image" and it will switch to the high res image.

Thanks

krosbonz commented 2 years ago

After a quick test it look like the px setting was the culprit. Thank you. Much appreciated.

Ottodix commented 2 years ago

The switch from high res to low res is because on the first play of a new album, the image cache doesn't exist yet. So foobar grab the full image, display it, and then add a copy to the cache with a resolution based on the settings (so very often a lower resolution). So on the next display of this album, the image cache exist, and so is displayed instead of the full image.