Mini player white progress bar bug

Ottodix / Eole-foobar-theme

Eole blows gently into your ear his nicest melodies.

1.37k stars 87 forks source link

Mini player white progress bar bug #3

Closed mjuzikfrik closed 5 years ago

mjuzikfrik commented 5 years ago

Hello,

I get an error mentioned below when I want to set playlist progress bar to white in the mini mode.

Error: Spider Monkey Panel v1.2.1 (MiniModePlaylist v1.0.0 by Ottodix)
progressbar_color_bg_off is not defined

File: WSHsmoothplaylist.js
Line: 2947, Column: 13

Stack trace:
  oBrowser/this.draw@WSHsmoothplaylist.js:2947:13
  on_paint@WSHsmoothplaylist.js:4693:16

edit. Same happens with right playlist. Also is it normal for cover to disappear from the right when I select transparent background or blurred for the main tracklist?

Ottodix commented 5 years ago

Hi!

My guess is that you've got some out of dates files. This variable, progressbar_color_bg_off, doesn't appears anymore in this file, WSHsmoothplaylist.js. Just update the theme. In a future version, i will include a version number directly in the error messages, because fixing issues from out of date version is impossible.

About your other question, i would say: first update the whole theme : ) And then if the issue is still there, make sure that you are using the wallpaper menu from the individual panels settings available with a right click > settings..., and not the wallpaper menu item available through foobar > skin settings > panel layout > wallpapers

mjuzikfrik commented 5 years ago

I downloaded the latest version from github. I made another new install, followed your hints and it still occurs. What's interesting is that the version before it - the 1.0.0 - is free from this issue.

edit. The cover on the right doesn't disappear too when changing background to for example transparent.

Ottodix commented 5 years ago

I'm sorry, but this is simply not possible, you are doing something wrong while doing your update. This variable, progressbar_color_bg_off, doesn't appears anymore in any of the files of this theme.

And with the background issue, i don't understand your issue neither. At least please provide me a clear step by step in order to reproduce your issue (where do you click, which menu items, etc...)

mjuzikfrik commented 5 years ago

Foobar2000 1.4.4. fresh portable install, latest version of Eole from github.

Ottodix commented 5 years ago

For the first error, related to the right playlist: It says it right on your error message that your theme is out of date: "RightPlaylist v1.0.0". Current version was 1.0.2, and i just updated it to 1.0.3a. Please update, and import again the columnUI file. And I repeat: your error message explain that the code is looking for a variable which doesn't exist ANYWHERE in the code. So, it really means that your foobar is using a older version of some of the js files, and this isn't a maybe. Please trust me, and make sure that your foobar is using the right files. My guess is that you are still using version 1.0.1. Reporting an issue is fine, but please try to follow my instructions.

For the second , i finaly understood what you are talking about. I fixed the error in the latest version, thanks for reporting. https://github.com/Ottodix/Eole-foobar-theme/releases/tag/1.0.3b

mjuzikfrik commented 5 years ago

I'm really sorry. For some reason I didn't see anything beyond 1.0.1. It works as expected now, though with 1.0.3b I have something like that.

mjuzikfrik commented 5 years ago

It looks like it's working now. Thanks!

Ottodix commented 5 years ago

Ok, great!