search

Ottodix / Eole-foobar-theme

Eole blows gently into your ear his nicest melodies.
1.33k stars 87 forks source link

There is a problem #48

Closed APECR-Username closed 4 years ago

APECR-Username commented 4 years ago

Many thanks to the author for a great theme for Foobar2000! The player’s functionality multiplied by such a modern and bright appearance leaves no chance for anything else. The following issues were found:

When you connect youtube source component allows you to get video covers. But for all videos, the same cover as the first is displayed in the right sidebar, playlist and in the bottom. You can only update manually through the context menu. I would like the covers to display correctly. In the worst case, for all streams to display one common standard cover, as for the radio. In doing so, the another panels detect and use the correct cover art for each video; In the library, covers for youtube source appear as empty squares. In the worst case, for all streams, one common standard cover could be displayed, as for a radio; In idle screen/screensaver, the right cover is not automatically updated when changing the album. In library mode, this is all right.

Ottodix commented 4 years ago

Hi,

Can you try the latest version there https://github.com/Ottodix/Eole-foobar-theme/zipball/master/?

It shoud be ok with this version, so I close this issue. Let me know if you still experience bugs There is still a little "glitch" when you play streams, the playlist refresh itself everytime you start playing a new stream and it's a little bit annoying, but for the moment I won't fix it, I can't think of any easy way to fix this.

APECR-Username commented 4 years ago

Much better. There are flaws in the video mode with YouTube: Library central panel. Background image. If the library is hidden by another tab, it is not updated (only YouTube). If the library is in the foreground, then the background image is updated. Playlist central panel. The background image is never updated (only YouTube). Side right panel. The background image is never updated (only YouTube). Screen saver mode. The album picture does not update (regardless of the source). A similar function in the library works correctly.

Ottodix commented 4 years ago

I did an update which should fix most of those bugs, let me know For the screen saver, this bug not a surprise, i never use this panel personnaly, I coded it a long time ago but actually never use it. But I fixed it

APECR-Username commented 4 years ago

Excellent. Everything was perfect!

APECR-Username commented 4 years ago

Although this is not a problem, but rather a proposal, but in order not to multiply the topics I will write here. The name of the artist next to each track in the library and screen saver is displayed in regular font. Apparently, according to the idea, it should be displayed in italics, as in the playlist and the right side panel. The splash screen mode would be more logical to immediately display in full screen (with the taskbar overlapping), and exiting the splash screen mode would automatically open the task bar. In screen saver mode, the progress bar according to option does not work. Instead, the progress bar is white. The non-disconnectable title_bar search bar in mini mode may not be needed, especially since there is a disconnectable search in the mini settings.

Ottodix commented 4 years ago

I did a change regarding the artist's name in the library, now it's in italic in the nighly About the other changes and little issues, i won't implement/fix them.

APECR-Username commented 4 years ago

After a recent update, the problem returned: Library central panel. Background image. If the library is hidden by another tab, it is not updated (only YouTube). If the library is in the foreground, then the background image is updated.

Ottodix commented 4 years ago

I can't reproduce this bug. Does it happens all the time, with every songs? Can you reproduce this bug or does it happens randomly?

APECR-Username commented 4 years ago

WSHsmoothplaylist_trackinfos.js: if(old_cachekey!=nowplaying_cachekey) { -> if(old_cachekey!=nowplaying_cachekey || !fb.IsMetadbInMediaLibrary(metadb)) { //☺