Ouckah / Summer2025-Internships

Collection of Summer 2025 tech internships!
417 stars 7 forks source link

Same Company Automation #33

Closed Ouckah closed 1 week ago

Ouckah commented 2 weeks ago

Group listings with the same company in the same section of the list, image provided.

This change must also effect how we read from .github/scripts/listings.json!

image

vanshb03 commented 2 weeks ago

Love the idea but curious on what will need to be amended to support this;

For example: If a company releases ROLE 1 on May 2nd but Role 2 on May 5th, in the case we group them, we will either;

Thoughts? @Ouckah @JhaoZ

Ouckah commented 2 weeks ago

Love the idea but curious on what will need to be amended to support this;

For example: If a company releases ROLE 1 on May 2nd but Role 2 on May 5th, in the case we group them, we will either;

  • Change the date of Role 2 to be on an previous date and then do the grouping
  • Change the date of Role 1 to be sooner and then do the grouping
  • Discard the sorting done based on dates currently

Thoughts? @Ouckah @JhaoZ

I think the second option is optimal, just bump up the previous roles so the user doesn't have to scroll down to see the new roles.

Ouckah commented 1 week ago

Gonna make a branch and try to work this out.

Ouckah commented 1 week ago

That did not work.

Ouckah commented 1 week ago

Fixed, going to open a new issue for the NEW issue!