search

OueslatiGhaith / stm32wb-hci

Bluetooth HCI implementation for embedded Rust
Apache License 2.0
3 stars 4 forks source link

Vendor Status Code Mismatch #9

Open TaylorCarpenter opened 5 months ago

TaylorCarpenter commented 5 months ago

Where are the VendorStatus codes coming from. There are a handful of codes that don't match anything that I can find. For example, VendorStatus::InvalidParameters is defined as 0x42. But based on the BLE spec, 0x42 should be UnknownAdvertisingIdentifier and based on the STM32 documentation (https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Middlewares/ST/STM32_WPAN/ble/core/doc/STM32WB_BLE_Wireless_Interface.html), InvalidParameters should be 0x92.

TaylorCarpenter commented 5 months ago

I want to make sure I am not missing some data source that was used to generate these. If it is just mistakes, I will cross-reference the documents and make the appropriate changes.

OueslatiGhaith commented 5 months ago

hello @TaylorCarpenter this repo is originally a fork of bluetooth-hci with the vendor-specific commands and events found in eupn's stm32wb55 and async support applied on top. As for references, I mainly use the ST repo, but I have not double-checked everything. I appreciate you pointing that out, and you seem to be correct, so feel free to open a PR