Open Oufattole opened 2 weeks ago
src/meds_torch/data/datamodule.py
pytorch_dataset
multiwindow_pytorch_dataset
Current config files combine settings for both DataModule and Dataset classes:
src/meds_torch/configs/data/ ├── pytorch_dataset.yaml └── random_windows_pytorch_dataset.yaml
Separate dataset-specific configs from DataModule configs:
src/meds_torch/configs/data/ ├── datamodule.yaml └── dataset_type/ ├── pytorch_dataset.yaml └── random_windows_pytorch_dataset.yaml
The main reason for this is so that users can use their own custom dataset files and configs, and select them via hydra.
Current Structure
Code Organization
src/meds_torch/data/datamodule.py
can contain either:pytorch_dataset
classmultiwindow_pytorch_dataset
classConfiguration Files
Current config files combine settings for both DataModule and Dataset classes:
Proposed Changes
New Configuration Structure
Separate dataset-specific configs from DataModule configs:
Benefits
The main reason for this is so that users can use their own custom dataset files and configs, and select them via hydra.
Implementation Tasks