Oufattole / meds-torch

MIT License
11 stars 1 forks source link

Dev #33

Closed Oufattole closed 2 weeks ago

Oufattole commented 2 weeks ago

MEDS v0.3 compatible

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

[!WARNING]

Rate limit exceeded

@Oufattole has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 18 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 63b9705308b8b17ccf9b305cb3625355b5516399 and e5a2935ad4c206129ad2ece19781dea3493bf3e7.

Walkthrough

The changes include updates to GitHub Actions workflows, configuration files for documentation, and enhancements to data processing scripts. Key modifications involve broadening pre-commit checks, restructuring documentation, and refining YAML configurations for model training and evaluation. New utility scripts for data extraction and normalization were introduced, while existing functions were improved for clarity and functionality. Additionally, a workflow for publishing Python packages to PyPI and TestPyPI was established.

Changes

File(s) Change Summary
.github/workflows/code-quality-pr.yaml Changed extra_args from --files ${{ steps.file_changes.outputs.files}} to --all-files for broader pre-commit checks.
.pre-commit-config.yaml Updated exclude pattern from "sample_data|docs/MIMIC_IV_tutorial/wandb_reports" to "tests/test_data".
.readthedocs.yaml New configuration file for Read the Docs, specifying build settings and linking to mkdocs.yml.
MIMICIV_TUTORIAL/README.MD Added README file with setup instructions for converting MIMIC IV data into MEDS format.
README.md Updated project description and key features, emphasizing flexibility and machine learning applications.
pyproject.toml Updated build system requirements and project configuration, including dynamic versioning.
src/meds_torch/data/components/pytorch_dataset.py Added new functions and modified existing ones for improved data handling.
src/meds_torch/models/components/mamba.py Enhanced error handling for positional encoding configurations.
src/meds_torch/models/components/transformer_decoder.py Improved handling of positional embeddings and added error checks.
src/meds_torch/models/components/transformer_encoder.py Enhanced initialization logic for model parameters based on configuration settings.
tests/helpers/extract_test_data.py New file providing a testing framework for the extraction process of patient data.
.github/workflows/publish-to-pypi.yml New workflow configuration for publishing Python distributions to PyPI and TestPyPI, including build, publish, and sign jobs.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Script
    participant Data
    participant Model

    User->>Script: Start extraction process
    Script->>Data: Generate synthetic patient data
    Data-->>Script: Return patient data
    Script->>Model: Process data
    Model-->>Script: Return processed data
    Script-->>User: Extraction complete

šŸ‡ In the code and the data,
Changes hop and play,
New scripts and paths,
A brighter way!
With models and methods,
We leap and bound,
In the world of MEDS,
Joyfully found! šŸ‡


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.42424% with 29 lines in your changes missing coverage. Please review.

Project coverage is 75.49%. Comparing base (64422fe) to head (e5a2935). Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
src/meds_torch/data/components/pytorch_dataset.py 81.81% 18 Missing :warning:
src/meds_torch/__init__.py 60.00% 2 Missing :warning:
src/meds_torch/models/components/mamba.py 0.00% 2 Missing :warning:
src/meds_torch/input_encoder/triplet_encoder.py 66.66% 1 Missing :warning:
...eds_torch/models/components/transformer_decoder.py 75.00% 1 Missing :warning:
...eds_torch/models/components/transformer_encoder.py 75.00% 1 Missing :warning:
.../models/components/transformer_encoder_attn_avg.py 75.00% 1 Missing :warning:
src/meds_torch/models/components/utils.py 75.00% 1 Missing :warning:
src/meds_torch/models/token_forecasting.py 50.00% 1 Missing :warning:
tests/conftest.py 94.11% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 75.51% 75.49% -0.03% ========================================== Files 42 43 +1 Lines 2271 2346 +75 ========================================== + Hits 1715 1771 +56 - Misses 556 575 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.