search

OurTechCommunity / catchup

The OTC CatchUp web app and workflows.
https://catchup.ourtech.community
MIT License
15 stars 9 forks source link

Add PR checklist. #125

Open HarshKapadia2 opened 1 year ago

HarshKapadia2 commented 1 year ago

Add PR checklist primarily to remind people to run Prettier before opening a PR.

Credits: @KartikSoneji

PS: Which label should one apply to such an issue? Do we need a new label? If yes, what would it be called?

KartikSoneji commented 1 year ago

I was actually thinking of making it an optional pre-commit hook that people can enable if they choose to.

KartikSoneji commented 1 year ago

Oh just saw #126. Closing this in favour of that.

HarshKapadia2 commented 1 year ago

Wait why not have both, an optional pre-commit hook and a PR checklist template, @KartikSoneji?

The pre-commit hook gives an additional way to use Prettier and the checklist serves as a reminder if one hasn't used Prettier...