Closed tusharnankani closed 1 year ago
We can also choose to have summary/map.json
in our .gitignore
. I think it makes sense.
@tusharnankani any updates?
I think these scripts should be in utils folder. (Sorry missed that in previous review)
Agreed, missed that.
File name convention?
@tusharnankani get-*
directly print to the console.
catchup-number.js
is a common file with functions that both utilities use.
Oh okay.
I wanted to ask what should I use as the convention?
create-attendee-twitter-map.js
AND map-twitter-handles-to-catchup-attendees.js
A single file is fine, just wrap the call to main()
in if(require.main)
.
Oh okay.
I wanted to ask what should I use as the convention?
create-attendee-twitter-map.js
ANDmap-twitter-handles-to-catchup-attendees.js
Don't use Twitter in name... Keep it generic
A bit of nitpicking (Not necessary to fix)
It adds an extra .
at the end
A bit of nitpicking (Not necessary to fix)
It adds an extra
.
at the end
It is working fine?
EDIT:
Just realized, if we add an extra line, it adds another item in a list. Fixing it.
Fixed.
Should I merge?
Pinging @OurTechCommunity/core
Looks good
Imp: https://github.com/OurTechCommunity/catchup/pull/140#discussion_r1125698761
The regex creates three groups now:
Closes #139
Final PoC: tusharnankani/jsonexp
Steps
Documentation: catchup/util
~To run scripts:~
~-
node createTwitterHandleMap.js
~ ~-map.json
created~ ~-node mapToAttendee.js
(for the respective path)~ ~-attendees.adoc
file in respective path edited~Edge Cases
Need to be figured out.