OurTechCommunity / catchup

The OTC CatchUp web app and workflows.
https://catchup.ourtech.community
MIT License
15 stars 9 forks source link

feat: add script to automate attendees linking #140

Closed tusharnankani closed 1 year ago

tusharnankani commented 1 year ago

Closes #139

Final PoC: tusharnankani/jsonexp

Steps

Documentation: catchup/util

~To run scripts:~

~- node createTwitterHandleMap.js~ ~- map.json created~ ~- node mapToAttendee.js (for the respective path)~ ~- attendees.adoc file in respective path edited~

Edge Cases

Need to be figured out.

tusharnankani commented 1 year ago

We can also choose to have summary/map.json in our .gitignore. I think it makes sense.

SirusCodes commented 1 year ago

@tusharnankani any updates?

tusharnankani commented 1 year ago

I think these scripts should be in utils folder. (Sorry missed that in previous review)

Agreed, missed that.

image

File name convention?

KartikSoneji commented 1 year ago

@tusharnankani get-* directly print to the console. catchup-number.js is a common file with functions that both utilities use.

tusharnankani commented 1 year ago

Oh okay.

I wanted to ask what should I use as the convention?

create-attendee-twitter-map.js AND map-twitter-handles-to-catchup-attendees.js

KartikSoneji commented 1 year ago

A single file is fine, just wrap the call to main() in if(require.main).

SirusCodes commented 1 year ago

Oh okay.

I wanted to ask what should I use as the convention?

create-attendee-twitter-map.js AND map-twitter-handles-to-catchup-attendees.js

Don't use Twitter in name... Keep it generic

SirusCodes commented 1 year ago

A bit of nitpicking (Not necessary to fix)

It adds an extra . at the end

image

tusharnankani commented 1 year ago

A bit of nitpicking (Not necessary to fix)

It adds an extra . at the end

image

image

It is working fine?

EDIT:

Just realized, if we add an extra line, it adds another item in a list. Fixing it.

tusharnankani commented 1 year ago

Fixed.

tusharnankani commented 1 year ago

Should I merge?

tusharnankani commented 1 year ago

Pinging @OurTechCommunity/core

PranavDani commented 1 year ago

Looks good

tusharnankani commented 1 year ago

Imp: https://github.com/OurTechCommunity/catchup/pull/140#discussion_r1125698761

The regex creates three groups now:

image

image