OurTechCommunity / catchup

The OTC CatchUp web app and workflows.
https://catchup.ourtech.community
MIT License
15 stars 9 forks source link

:sparkles: feat: Add 'Improve Content' section to summary #159

Closed sushma1031 closed 1 year ago

sushma1031 commented 1 year ago

Fixes issue #146 Demo: https://github.com/OurTechCommunity/catchup/assets/123486589/7ac7398c-a5eb-40ce-ab04-2f4aa1f6a318

tusharnankani commented 1 year ago

Amazing work, @sushma1031 Can you share the final screenshot/screen recording of the page?

sushma1031 commented 1 year ago

@tusharnankani Will do!

sushma1031 commented 1 year ago

@tusharnankani I edited the pull request description to include the screen recording, let me know if everything's fine!

tusharnankani commented 1 year ago

Looks perfect! +_+

sushma1031 commented 1 year ago

I'm glad I could contribute! Thanks @tusharnankani & @HarshKapadia2 for guiding me through it :)

sushma1031 commented 1 year ago

I'll work on the changes @HarshKapadia2 , thanks for letting me know

sushma1031 commented 1 year ago

@HarshKapadia2 Done with the changes 👍

HarshKapadia2 commented 1 year ago

We'll just wait for @KartikSoneji to review the PR as well, as he wanted a particular change with converting classes to IDs, so that we're able to link to those sections using hash fragments.

HarshKapadia2 commented 1 year ago

Also just a note @sushma1031, that you can directly commit review suggestions by clicking the 'Commit suggestion' button below them. You don't need to manually commit them. (Note that the person who suggests does get co-authorship.)

sushma1031 commented 1 year ago

Thank you so much for contributing, @sushma1031! Thank you for being prompt as well!

My pleasure!

We'll just wait for @KartikSoneji to review the PR as well, as he wanted a particular change with converting classes to IDs, so that we're able to link to those sections using hash fragments.

All right.

Also just a note @sushma1031, that you can directly commit review suggestions by clicking the 'Commit suggestion' button below them. You don't need to manually commit them. (Note that the person who suggests does get co-authorship.)

Ah, all right, I did notice that feature but I wasn't sure if I should use it or not, thanks for letting me know!

sushma1031 commented 1 year ago

All right, I'll make the requested changes.

Just to clarify, these are the changes to be made:

  1. Change 0.94em to 1em
  2. Change [.improve-heading] to [#improve-content]
  3. Rename the second link ("Report the content issue") to "Report the issue."

If I've gotten anything wrong, please let me know.

sushma1031 commented 1 year ago

@KartikSoneji Made the requested changes. It now appears like this: image

image

tusharnankani commented 1 year ago

Looks good.

@KartikSoneji, please let us know if we are good to go.

HarshKapadia2 commented 1 year ago

Thank you so much, @sushma1031 and sorry for the delay in merging the PR!

sushma1031 commented 1 year ago

I'm glad I could help, and thanks for all the guidance! 😊