search

OurTechCommunity / catchup

The OTC CatchUp web app and workflows.
https://catchup.ourtech.community
MIT License
15 stars 9 forks source link

⬆️ Bump ansi-regex from 4.1.0 to 4.1.1 #48

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 2 years ago

Bumps ansi-regex from 4.1.0 to 4.1.1.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/OurTechCommunity/catchup/network/alerts).
tusharnankani commented 2 years ago

Why aren't we merging these?

cc: @HarshKapadia2 @KartikSoneji

HarshKapadia2 commented 2 years ago

Depandabot has driven me absolutely insane with the number of PRs on my repos. I have ignored of all its PRs. I have to configure it properly, I guess. IDK.

IDK if it's the best practice to randomly merge package updates. I think we will have to check that every PR doesn't break something.

To be fair though, minor or patch updates generally don't have breaking changes and it is usually the major updates that have breaking changes, but still we would have to check the release page of each package for that.

What do you think @KartikSoneji?

KartikSoneji commented 2 years ago

IDK if it's the best practice to randomly merge package updates. I think we will have to check that every PR doesn't break something.

If we have unit/end to end tests then we can automatically merge them if the tests pass. That is what a lot of projects do.

tusharnankani commented 2 years ago

auto-merge PR; we can use a simple GitHub Action.

HarshKapadia2 commented 2 years ago

auto-merge PR; we can use a simple GitHub Action.

We can just use GitHub's in-built functionality for auto-merging PRs as suggested in the automerge-action repo that you shared, @tusharnankani, but that is secondary. What @KartikSoneji suggested (Unit Testing) is required first, but IDK if we have the time for that or if that is really necessary at this point.