Feat: better `/summary` routing

OurTechCommunity / catchup

The OTC CatchUp web app and workflows.

https://catchup.ourtech.community

MIT License

15 stars 9 forks source link

Feat: better `/summary` routing #75

Closed KartikSoneji closed 2 years ago

KartikSoneji commented 2 years ago

Use canonical numbering for /summary/:catchupNumber route
Add route /summary/latest to redirect to latest summary
Add route /summary/random to redirect to a random summary
misc: Add linebreaks to error message in 404 and index.html

tusharnankani commented 2 years ago

Wondering about feat-better-/summary-routing branch name. Does it matter? cc: @HarshKapadia2

HarshKapadia2 commented 2 years ago

Reply to what @tusharnankani said:

Wondering about feat-better-/summary-routing branch name. Does it matter? cc: @HarshKapadia2

Yes, it provides context, which is important.

Reply to what @tusharnankani said:

What do you think about the extra Random Button @HarshKapadia2? I think it sounds good.

I have my reservations, as I mentioned in my review. LMK your thoughts by commenting there. (My comment is available for comments under Darshan's review comment.)

tusharnankani commented 2 years ago

Yes, it provides context, which is important.

No, of course I understand that xD

I meant the '/' typo in between.

HarshKapadia2 commented 2 years ago

Yes, it provides context, which is important.

No, of course I understand that xD

I meant the '/' typo in between.

The / is not a typo, it is indicating a route @tusharnankani, and I'm guessing you understood that. It threw me off for a bit as well and maybe feat-better-summary-routing would have sufficed.

tusharnankani commented 2 years ago

Ah okay. Understood.

HarshKapadia2 commented 2 years ago

Sorry if I was presumptuous, @tusharnankani.

The / is not a typo, it is indicating a route @tusharnankani, and I'm guessing you understood that.

KartikSoneji commented 2 years ago

It threw me off for a bit as well and maybe feat-better-summary-routing would have sufficed.

That is what I had named the branch first, but when I came back a week later, I had to look though the commit history to remember what I meant by "summary routing". So I added the / to indicate it was the /summary route.