Closed sreekaransrinath closed 2 years ago
cc @HarshKapadia2
@tusharnankani have a look and merge of looks fine to you as well
@KartikSoneji @HarshKapadia2 requesting review
Just realised, this doesn't actually fix the duplicate title in the individual summary page.
@KartikSoneji what do you mean?
Ah damn, okay.
In #71, the issue is to remove the redundant OTC CatchUp #90 Summary
.
I see what it is -
The first title comes from the individual-summary.adoc line 1.
The second is from combined-summary-template.adoc line 1.
Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page?
I can delete either and send in a PR, but deleting the one in the template might have unintended consequences if it also serves elsewhere.
Bump @KartikSoneji @tusharnankani
Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page?
No. The combined summary template is also used to build, well, the combined summary.
The fix will be a bit more involved with this one, I'll leave a comment with more details on the issue.
Fixes #71