OurTechCommunity / catchup

The OTC CatchUp web app and workflows.
https://catchup.ourtech.community
MIT License
15 stars 9 forks source link

:adhesive_bandage: Remove duplicate title in individual summaries #89

Closed sreekaransrinath closed 2 years ago

sreekaransrinath commented 2 years ago

Fixes #71

sreekaransrinath commented 2 years ago

cc @HarshKapadia2

SirusCodes commented 2 years ago

@tusharnankani have a look and merge of looks fine to you as well

sreekaransrinath commented 2 years ago

@KartikSoneji @HarshKapadia2 requesting review

KartikSoneji commented 2 years ago

Just realised, this doesn't actually fix the duplicate title in the individual summary page.

sreekaransrinath commented 2 years ago

@KartikSoneji what do you mean?

tusharnankani commented 2 years ago

Ah damn, okay.

In #71, the issue is to remove the redundant OTC CatchUp #90 Summary.

sreekaransrinath commented 2 years ago

I see what it is -

The first title comes from the individual-summary.adoc line 1.

The second is from combined-summary-template.adoc line 1.

Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page?

I can delete either and send in a PR, but deleting the one in the template might have unintended consequences if it also serves elsewhere.

sreekaransrinath commented 2 years ago

Bump @KartikSoneji @tusharnankani

KartikSoneji commented 2 years ago

Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page?

No. The combined summary template is also used to build, well, the combined summary.

The fix will be a bit more involved with this one, I'll leave a comment with more details on the issue.