codecov-commenter
commented
1 year ago Codecov Report
Base: 80.52% // Head: 80.39% // Decreases project coverage by -0.14% :warning:
Coverage data is based on head (
e0ba532) compared to base (cf46571). Patch coverage: 59.42% of modified lines in pull request are covered.:exclamation: Current head e0ba532 differs from pull request most recent head 578e8bc. Consider uploading reports for the commit 578e8bc to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #571 +/- ## ========================================== - Coverage 80.52% 80.39% -0.14% ========================================== Files 72 72 Lines 9821 9868 +47 Branches 1359 1375 +16 ========================================== + Hits 7908 7933 +25 - Misses 1600 1618 +18 - Partials 313 317 +4 ``` | [Impacted Files](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc) | Coverage Δ | | |---|---|---| | [magpie/api/exception.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FwaS9leGNlcHRpb24ucHk=) | `92.45% <0.00%> (-1.42%)` | :arrow_down: | | [magpie/api/login/login.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FwaS9sb2dpbi9sb2dpbi5weQ==) | `57.36% <0.00%> (-0.31%)` | :arrow_down: | | [magpie/security.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL3NlY3VyaXR5LnB5) | `93.93% <ø> (ø)` | | | [magpie/utils.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL3V0aWxzLnB5) | `68.64% <56.52%> (-1.16%)` | :arrow_down: | | [magpie/adapter/\_\_init\_\_.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FkYXB0ZXIvX19pbml0X18ucHk=) | `87.95% <71.42%> (-0.15%)` | :arrow_down: | | [magpie/\_\_meta\_\_.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL19fbWV0YV9fLnB5) | `100.00% <100.00%> (ø)` | | | [magpie/app.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FwcC5weQ==) | `89.65% <100.00%> (+0.12%)` | :arrow_up: | | [magpie/ui/login/views.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL3VpL2xvZ2luL3ZpZXdzLnB5) | `65.71% <100.00%> (+0.49%)` | :arrow_up: | | [magpie/ui/utils.py](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL3VpL3V0aWxzLnB5) | `67.50% <100.00%> (+0.10%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/Ouranosinc/Magpie/pull/571?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Features / Changes
twitcher>=0.8.0.ResponseFactorythat inserts therequestreference within producedresponseobjects when handled bypyramidhandlers. This is to ensure better alignment of expected object references with other code sections, such as in theMagpieAdapter.get_registryutility function and adjustget_settingsthat reuses common operations between them.Bug Fixes
MagpieAdapterto employ the newsend_requestmethod (twitcher>=0.8.0) in order to inject the missingresponse.requestreference within the proxied response when therequestsmodule was used to perform the request. This resolves aNonereference that caused most of theMagpieAdapter.response_hookto fail.