Ouranosinc / Magpie

AuthN/AuthZ services
https://pavics-magpie.readthedocs.io
Apache License 2.0
1 stars 5 forks source link

add service type to permission webhooks #582

Closed ChaamC closed 1 year ago

ChaamC commented 1 year ago

Add the service.type data in the Webhooks for a Permission change, even if the resource is not a service, since the root service type is necessary to Cowbird.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (63b0fb3) 80.76% compared to head (45f6085) 80.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #582 +/- ## ======================================= Coverage 80.76% 80.77% ======================================= Files 73 73 Lines 10160 10162 +2 Branches 1816 1816 ======================================= + Hits 8206 8208 +2 Misses 1630 1630 Partials 324 324 ``` | [Impacted Files](https://app.codecov.io/gh/Ouranosinc/Magpie/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc) | Coverage Δ | | |---|---|---| | [magpie/api/management/group/group\_utils.py](https://app.codecov.io/gh/Ouranosinc/Magpie/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FwaS9tYW5hZ2VtZW50L2dyb3VwL2dyb3VwX3V0aWxzLnB5) | `90.06% <100.00%> (ø)` | | | [magpie/api/management/user/user\_utils.py](https://app.codecov.io/gh/Ouranosinc/Magpie/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FwaS9tYW5hZ2VtZW50L3VzZXIvdXNlcl91dGlscy5weQ==) | `97.21% <100.00%> (ø)` | | | [magpie/api/webhooks.py](https://app.codecov.io/gh/Ouranosinc/Magpie/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ouranosinc#diff-bWFncGllL2FwaS93ZWJob29rcy5weQ==) | `85.91% <100.00%> (+0.20%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.