Closed mishaschwartz closed 1 year ago
@fmigneault I'd like to add some tests to this as well.
I was unable to find the current tests that check the user creation routes. I'm probably just looking in the wrong place. Any help would be greatly appreciated.
@mishaschwartz
I was unable to find the current tests that check the user creation routes. I'm probably just looking in the wrong place. Any help would be greatly appreciated.
Should be in https://github.com/Ouranosinc/Magpie/blob/master/tests/interfaces.py. Classes in there are reused by https://github.com/Ouranosinc/Magpie/blob/master/tests/test_magpie_api.py and https://github.com/Ouranosinc/Magpie/blob/master/tests/test_magpie_ui.py for various local/remote admin/public testing combinations.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
36208d8
) 80.84% compared to head (436c7f9
) 80.92%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mishaschwartz Thanks for the PR and tests! https://github.com/Ouranosinc/Magpie/tree/3.37.0 pushed 🚀
Create an additional settings/environment variable
MAGPIE_SUPPLEMENTAL_USERNAME_REGEX
that acts as an additional check for whether ausername
is valid. This creates a further restriction on this value which is useful when there are additional limits on theusername
that should be enforced byMagpie
.Resolves #497