Ouranosinc / Magpie

AuthN/AuthZ services
https://pavics-magpie.readthedocs.io
Apache License 2.0
1 stars 5 forks source link

Maintenance update #606

Closed fmigneault closed 4 months ago

fmigneault commented 4 months ago

Changes

[!NOTE]
Requires patch of authomatic.six.moves in magpie.__init__.py to work around vendor-specific definitions. Fix inspiration from https://github.com/dpkp/kafka-python/issues/2401#issuecomment-1760208950. Pending official fix (see https://github.com/authomatic/authomatic/issues/233).

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.88%. Comparing base (d899bd2) to head (c59b2c9). Report is 4 commits behind head on master.

Files Patch % Lines
magpie/__init__.py 0.00% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #606 +/- ## ========================================== - Coverage 80.92% 80.88% -0.04% ========================================== Files 73 73 Lines 10196 10201 +5 Branches 1824 1825 +1 ========================================== Hits 8251 8251 - Misses 1622 1626 +4 - Partials 323 324 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fmigneault commented 4 months ago

[!NOTE] Failing tests (ubuntu-latest, 3.7, false, test-local) is expected, since it was removed from the CI. The rule will be removed from the PR merge requirements once this PR is integrated (such that any PR in the meantime still respect the requirement). Coverage diff is only related to the Python 3.12 patch, which is not worth testing by itself (the fact that all other tests executed with 3.12 is enough of an indicator that it works).