search

Ouranosinc / Magpie

AuthN/AuthZ services
https://pavics-magpie.readthedocs.io
Apache License 2.0
1 stars 5 forks source link

fix permissions update from config using requests code path #610

Closed fmigneault closed 3 months ago

fmigneault commented 3 months ago

Tested using magpie.register.magpie_register_permissions_from_config from a script with a set of Permission entries and a remote Magpie instance URL. Updates applied where things broke.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (154736d) to head (5ee83c5). Report is 1 commits behind head on master.

:exclamation: Current head 5ee83c5 differs from pull request most recent head 5285b6e

Please upload reports for the commit 5285b6e to get more accurate results.

Files Patch % Lines
magpie/register.py 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #610 +/- ## ======================================= Coverage 80.88% 80.88% ======================================= Files 73 73 Lines 10201 10191 -10 Branches 1825 1825 ======================================= - Hits 8251 8243 -8 + Misses 1626 1625 -1 + Partials 324 323 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fmigneault commented 3 months ago

Added #612 which tests the requests code path while evaluating it.