Ouranosinc / PAVICS-e2e-workflow-tests

Test user-level workflow.

Apache License 2.0

0 stars 2 forks source link

Cowbird jupyter e2e test #131

Closed ChaamC closed 9 months ago

ChaamC commented 10 months ago

Overview

Adds a new test to check the user's workspace in a JupyterLab environment that also uses Cowbird. It checks if the different expected folders are set up properly and if the user has the right permissions on the different test files. The test preparation is done with a script run by a new optional-component test-cowbird-jupyter-access found on birdhouse.

Note that test is split in 2 notebooks :

notebooks-auth/test_cowbird_jupyter.ipynb : this notebook is the one executed on the container started by Jenkins. His responsability is to start a JupyterLab instance using the JupyterHub API. This instance will then run the actual tests.
notebooks-auth/resources/user_test_cowbird_jupyter.ipynb : this notebook is the one executed on the JupyterLab container and which contains the actual tests.

Related Issue / Discussion

birdhouse PR #404

review-notebook-app[bot] commented 10 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tlvu commented 10 months ago

Nice. I always wanted a notebook test for Cowbird because I have not fully understand what it does.

Will try this next week and report back.

By the way, I assume it was tested successfully on Jenkins? No mention in the PR description about this crucial point.

fmigneault commented 10 months ago

@tlvu

By the way, I assume it was tested successfully on Jenkins? No mention in the PR description about this crucial point.

It ran successfully on this commit: https://github.com/bird-house/birdhouse-deploy/pull/404/commits/9d715b9a8e605632669f43b4b29d8f055e0b7994 (http://daccs-jenkins.crim.ca/job/DACCS-iac-birdhouse/2248/)

However, it needs to be tested again after all changes are applied and using the recently tagged https://github.com/Ouranosinc/cowbird/tree/2.2.0.

ChaamC commented 9 months ago

@fmigneault @tlvu This should be ready for a new review. Fixed the different mentionned comments and some remaining bugs. E2E tests are still running, but this specific notebook was successful : http://daccs-jenkins.crim.ca/job/PAVICS-e2e-workflow-tests/job/cowbird-jupyter-e2e-test/47/

ChaamC commented 9 months ago

@tlvu Just to make sure, was this PR good to merge too?

tlvu commented 9 months ago

@ChaamC yes good to merge for me. I had not have time to try it yet but since this is not enabled by default, it won't break our production run, so I do not have to try it first. Thanks for these tests. I am sure it will help understand cowbird better.