search

Ouranosinc / PAVICS-e2e-workflow-tests

Test user-level workflow.
Apache License 2.0
0 stars 2 forks source link

Jenkins: allow to programmatically override all params in Jenkinsfile #136

Closed tlvu closed 4 months ago

tlvu commented 4 months ago

This new CONFIG_PARAMETERS_SCRIPT_URL is different than the previous CONFIG_OVERRIDE_SCRIPT_URL in that it overrides all the Jenkins params much sooner so all regular processing can take place.

When the regular processing are not enough and we need additional customizations, then we use the other CONFIG_OVERRIDE_SCRIPT_URL.

The two override scripts complement each other by hooking into the process at different moment in time, and together they allow full complete override of the various options for the test run.

Furthermore, CONFIG_OVERRIDE_SCRIPT_URL can also be a local file that is created on the fly by CONFIG_PARAMETERS_SCRIPT_URL so in the end, only CONFIG_PARAMETERS_SCRIPT_URL is needed for a full complete override.

tlvu commented 4 months ago

I would suggest using another name to make this distinction clearer. Maybe CONFIG_PARAMETERS_SCRIPT_URL or similar? Basically, avoiding the "override" mention.

You are absolutely right. The naming could be better. Will do this.

tlvu commented 4 months ago

FYI, @fmigneault I added a new capability: CONFIG_OVERRIDE_SCRIPT_URL can also be a local file that is created on the fly by CONFIG_PARAMETERS_SCRIPT_URL so in the end, only CONFIG_PARAMETERS_SCRIPT_URL is needed for a full complete override.