search

Ouranosinc / PAVICS-e2e-workflow-tests

Test user-level workflow.
Apache License 2.0
0 stars 2 forks source link

Jenkins: allow to customize py.test options for --nbval-lax and a few other minor fixes #69

Closed tlvu closed 3 years ago

tlvu commented 3 years ago

@huard we will be able to optionally provide --nbval-lax for Raven notebooks (will help for the up-coming Raven demo).

@MatProv I kept it a text box so we have the flexibility to add other py.test options later without having to modify the Jenkins UI again.

@fmigneault Your previous Branch chars PR https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/65, the . (dot) was also not replaced in the archive dir name. Also had to escape the - since it is the "range" operator.

Tested here https://daccs-jenkins.crim.ca/job/PAVICS-e2e-workflow-tests/job/minor-fixes-launchnotebook-nbval-lax-as-option/2/parameters/ (using pavics-sdi branch lvu-test.branch.name.with-dots and activating Raven notebooks with --nbval-lax, targetting my lvupavicsdev.ouranos.ca with latest Finch and Raven).

For the launchnotebook and launchcontainer script, see commit description of https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/commit/ee6af8c87389876e521816b6f2f74e3df83ac09b for the reason.

matprov commented 3 years ago

I kept it a text box so we have the flexibility to add other py.test options later without having to modify the Jenkins UI again.

Great, good idea, more flexibility. When calling from daccs-iac it will always be "--nbval-lax", but for advanced config we will have the textfield in pavics-e2e pipeline.

tlvu commented 3 years ago

When calling from daccs-iac it will always be "--nbval-lax"

@MatProv don't think you should make it the default on your side yet. It's not the default here so if you make it default on your side, you will not be testing the same as here.

It's meant to be easily activated if need be, ex for Raven notebooks.

matprov commented 3 years ago

It's not the default here

Ok then it'll simply be an option on daccs-iac.