Ouranosinc / PAVICS-e2e-workflow-tests

Test user-level workflow.
Apache License 2.0
0 stars 2 forks source link

Add PAVICS homepage notebooks to Jenkins testsuite and new Jupyter env build #79

Closed tlvu closed 3 years ago

tlvu commented 3 years ago

Overview

Matching required notebook changes PR https://github.com/Ouranosinc/PAVICS-landing/pull/29

Matching PAVICS PR deployment change to test this PR https://github.com/bird-house/birdhouse-deploy/pull/180

Matching PR to update pavics-landing deployment config https://github.com/bird-house/birdhouse-deploy-ouranos/pull/12

Other Changes

Related Issue / Discussion

Additional Information

matprov commented 3 years ago

@tlvu By curiosity, what's the difference between https://github.com/bird-house/birdhouse-deploy-ouranos and https://github.com/Ouranosinc/birdhouse-deploy?

tlvu commented 3 years ago

@matprov the birdhouse-deploy-ouranos is our custom override of generic birdhouse-deploy.

These are the stuff that can not even be in any kind of optional-components because they are too specific to Ouranos, example this https://github.com/bird-house/birdhouse-deploy-ouranos/blob/e284ab8ad99419cd0d7efde8884e3d3e1bdeb95b/ouranos-config/proxy/cruesdeca-redirect.conf.template#L1-L3 or our extra scheduler jobs that is only ever relevant to us https://github.com/bird-house/birdhouse-deploy-ouranos/tree/master/scheduler-jobs. testdata deploy jobs are included in the generic one because that can potentially be of interest to others.

matprov commented 3 years ago

@tlvu Oh yes, my bad, given the repo name I was confused but looking at the actual files in there makes sense.

What do you think about moving this under Ouranosinc/birdhouse-deploy-ouranos since we try to avoid any org specifics under bird-house organisation?

tlvu commented 3 years ago

What do you think about moving this under Ouranosinc/birdhouse-deploy-ouranos since we try to avoid any org specifics under bird-house organisation?

That would be ideal but not feasible at the moment since this e2e-workflow-test is not pluggable ! We have previously discussed in https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/issues/57.

Making this e2e-workflow-test repo pluggable will also allow you guys to test your EO and NLP image against your matching notebooks. Right now, the Jupyter image is hardcoded to ours, same as the notebooks :(