search

Ouranosinc / PAVICS-landing

The landing page serving as the entrance to PAVICS
1 stars 0 forks source link

Sync climate analysis notebook and a link to open in jupyterhub #19

Closed tlogan2000 closed 3 years ago

tlogan2000 commented 3 years ago

Add a user redirect link to climate analysis notebooks

tlogan2000 commented 3 years ago

@tlvu if you can take care of the sync .. I'll be able to do the rest. We can discuss if these should be tested on Jenkins. There might be a few issues in the length of time they take to run (notebook 3 in particular) but 4 and 5 depend on the output from 3... can discuss together this week

tlvu commented 3 years ago

@tlogan2000 sure, we can probably discuss on Wednesday. Trying to get Finch out the door and fixing the regridding notebook right now.

By the way, I don't quite understand 'Add 'open in PAVICS' user redirect links in the 'climate_analysis.html' iframes'. For Wednesday I guess.

tlogan2000 commented 3 years ago

@tlvu small addition ... with the notebooks there is a small subfolder 'tutorial_data' with a few geojsons that needs to be synced as well...

tlvu commented 3 years ago

Since notebook files in here is private, I assume we do not want them to show up on PAVICS deployment on other orgs?

For context, the "standard" tutorial notebook sync is available for all orgs that deploy PAVICS.

tlogan2000 commented 3 years ago

@tlvu examples are pretty specific to Ouranos and our jupyterhub I think. Can we keep them on our jupyter only for now? I am going to get some feedback over the next couple of weeks from ouranos people who will test drive the tutorial. Longer term I don't have a major issue with these becoming public examples though. Users would need a pavics jupyter account to run them on boreas, but other organizations should be able to run them making our thredds work a little bit but calculations running on their end. @huard any opinion on the visibility of the pavics-landing notebooks?

tlvu commented 3 years ago

Sorry just to be clear, I am usually for maximum sharing/public stuff but I am absolutely not against having things in-house only.

Except in this case, there a little technical hurdle for notebooks in a private repo: the standard way to deploy notebooks to Jupyter env and Jenkins test all assume public notebooks repos so this one will not fit without some good amount of refactoring.

It's one of the earlier things I did at Ouranos and it's much less "generic" compared to the few later things (the deploy any repos anywhere and the docker launcher that can launch any scripts that bring their own docker runtime, sort of BYOD but for scripts).

PR https://github.com/bird-house/birdhouse-deploy-ouranos/pull/8 to deploy notebooks here in this private repo is leveraging the "deploy any repos anywhere" and you see it's pretty much just config, almost no code, very generic mechanism.

So I do plan to modernize the old notebooks deploy mechanism as well, but it has never been high in priorities because there was no need for it, until now.

So short term I think we can live with 2 different notebook deployment mechanism, for long term, we should plan for a refactoring.

tlvu commented 3 years ago

Issue opened for the refactoring of the Jenkins test framework https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/issues/57

tlvu commented 3 years ago

@tlogan2000 Is this done? Or only missing the part about "Add 'open in PAVICS' user redirect links in the 'climate_analysis.html' iframes"

Notebooks sync already done in https://github.com/bird-house/birdhouse-deploy-ouranos/pull/8.

tlogan2000 commented 3 years ago

@tlogan2000 Is this done? Or only missing the part about "Add 'open in PAVICS' user redirect links in the 'climate_analysis.html' iframes"

Notebooks sync already done in bird-house/birdhouse-deploy-ouranos#8.

Yes I have this working now with the jupyter user-redirect links