search

Ouranosinc / PAVICS-landing

The landing page serving as the entrance to PAVICS
1 stars 0 forks source link

"Login/Register" button hardcoded to pavics.ouranos.ca #22

Closed tlvu closed 2 years ago

tlvu commented 3 years ago

The "Login/Register" button on the first page hardcode https://pavics.ouranos.ca/jupyter/hub/login, see landing page here https://lvupavics.ouranos.ca/ points to Jupyter on prod and not on the same server.

I think it would be preferable to use a relative link so it will point the Jupyter on the same server.

But this forces to have a local Jupyter running to "resolve" the relative link, which is not the case when we are not running a full PAVICS stack.

So I am okay if we keep the hardcode. I just want to raise the point that for all the various PAVICS dev and staging servers we have, this link will be wrong with the hardcode.

tlogan2000 commented 3 years ago

@tlvu ok noted. Thanks for catching that ...