search

Ouranosinc / PAVICS-landing

The landing page serving as the entrance to PAVICS
1 stars 0 forks source link

Use ESPO-G6-R2 in tutorials update nbs, tutorial data and html versions #81

Closed tlogan2000 closed 4 months ago

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tlogan2000 commented 5 months ago

@tlvu if you could try a jenkins run on this branch that would be great @aulemahal @huard updated to ESPO data for most tutorials. Tutorial 5 : tries to introduce xscen to replace previously 'homemade' sub-functions and advanced section more or less explains data treatment for Portraits Clim visuals and summaries

tlogan2000 commented 5 months ago

@aulemahal @huard I now see numerous typos in the markdown cells but you'll get the gist I think .. personally i'm stopping for the day ;) .. will come back to this on monday

review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

aulemahal commented on 2024-04-19T20:42:50Z ----------------------------------------------------------------

Line #14.    ds_url = "https://pavics.ouranos.ca/twitcher/ows/proxy/thredds/dodsC/datasets/reanalyses/day_ERA5_NAM.ncml"

Why not the url directly ? This list + indexing feels opaque for newcomers.


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

aulemahal commented on 2024-04-19T20:42:53Z ----------------------------------------------------------------

Line #47.                    xens.create_ensemble(ncfiles, calendar='standard').expand_dims(scen=[scen])


tlvu commented 5 months ago

@tlvu if you could try a jenkins run on this branch that would be great

Running http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/current-production-version/289/

tlvu commented 5 months ago

@tlvu if you could try a jenkins run on this branch that would be great

Running http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/current-production-version/289/

@tlogan2000 This would need the upcoming Jupyter env, which I need help with the other broken notebooks as well :(

nb 2:

PYTHON_SITE_PACKAGES/clisops/core/regrid.py:37: UserWarning: xESMF >= 0.8.2 is required to use the regridding operations.
warnings.warn(msg)

nb 5:

ModuleNotFoundError: No module named 'xscen'
tlvu commented 5 months ago

@tlvu if you could try a jenkins run on this branch that would be great

Testing against newer jupyter env: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/new-docker-build/301/console New nb seems fine, only need to refresh output.

So do not merge this PR before the new Jupyter env is live.

tlogan2000 commented 5 months ago

@tlvu thanks. Yes this is being updated in anticipation of the beta image

review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

huard commented on 2024-05-08T20:25:27Z ----------------------------------------------------------------

Maybe add link somewhere to notebook showing how to create map projections for those.

https://pavics-sdi.readthedocs.io/en/latest/notebooks/climex.html#creating-maps-of-climex-fields


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

huard commented on 2024-05-08T20:25:29Z ----------------------------------------------------------------

using containing (last bullet)


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

huard commented on 2024-05-08T20:25:30Z ----------------------------------------------------------------

Comma after extensions.


tlvu commented 5 months ago

master branch needs to merge into this PR.

tlogan2000 commented 4 months ago

@tlvu I think this is almost ready. For Jenkins runs there are now two .zip files for the data needed to run.

  1. content/notebooks/climate_indicators/tutorial3.zip : used in nb4 and 5
  2. content/notebooks/climate_indicators/tutorial5.zip : used with nb6
tlvu commented 4 months ago

Jenkins passed http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/current-production-version/302/console.

Merge when ready.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.