search

Ouranosinc / jenkins-config

Jenkins deployment configurations.
MIT License
0 stars 1 forks source link

upgraded jenkins-master image to 2.249.1.201005, remove unsupported j… #11

Closed matprov closed 4 years ago

matprov commented 4 years ago
tlvu commented 4 years ago

LGTM, merge when you are ready, thanks !

tlvu commented 4 years ago

@MatProv

FYI, to save you from making 2 different PR next time, you could have tagged and bump the tag in docker-compose.yml in the same previous PR. Once merged, the devel branch will become master branch so the tag is legit.

So we might end up with multiple releases/tags in the same PR if problems are found but I think we can live with this little mess if it makes the process lighter and faster for you. We are just 2 committers to this repo for now. I think we can try this until we see a real problems with this approach.

There is a date in the docker tag to allow "rebuild" on the same version of jenkins-master. If multiple rebuilds in the same day, we can append ".1" or ".2" and so on to the date.

tlvu commented 4 years ago

Oops sorry this is not the same repo as the other jenkins-master repo ! So yeah, can't save you from 2 districts PR.