Adjust `sd` conversion in ERA5 - Githubissues

Ouranosinc / miranda

A modern Python utility library for climate data collection and management

Apache License 2.0

18 stars 2 forks source link

Adjust `sd` conversion in ERA5 #107

Closed Zeitsperre closed 1 year ago

Zeitsperre commented 1 year ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #106
[ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Changes expected conversion of ECMWF sd variable to swe
Adds swe to list of variables that can be daily aggregated
Removes several overly-specific variable conversions according to projects

Does this PR introduce a breaking change?

Yes. sd does not convert to snw anymore. That conversion step should be handled by xclim (or perhaps a new helper function?)

Other information:

snw conversion function will now be in xclim: https://github.com/Ouranosinc/xclim/pull/1271

Zeitsperre commented 1 year ago

@tlogan2000 @aulemahal this is good to go