search

Ouranosinc / xclim

Library of derived climate variables, ie climate indicators, based on xarray.
https://xclim.readthedocs.io/en/stable/
Apache License 2.0
333 stars 59 forks source link

Fix deprecations in xarray #270

Closed huard closed 5 years ago

huard commented 5 years ago

Description

xarray 0.13 will deprecate a couple of usages we rely on. I suggest we list those and fix them in advance of the 0.13 release.

Zeitsperre commented 5 years ago

@Ouranosinc/hailstorm Looks like xarray 0.13 came out yesterday and a lot of usages are now broken. I can pin the requirements in a hotfix and push that to PyPI, but all new installations will now fail the test_subset.py test ensemble.

huard commented 5 years ago

I can spare an hour today on this.

tlogan2000 commented 5 years ago

Ok we should definitely push this up on the todo list

huard commented 5 years ago

Almost done. @Zeitsperre I'm hitting a snag. black and autopep8 are in conflict, so there is no way to commit my changes...

tlogan2000 commented 5 years ago

@huard are you fixing FutureWarnings only?... there are also test failing with xr v.0.13 I 've gone the route of upgrading xarray and am working through things that are completely broken

huard commented 5 years ago

No, fixing broken subset stuff as well.

tlogan2000 commented 5 years ago

sounds good I will wait for your commits.. was just getting started

huard commented 5 years ago

Check the PR I just made. WIP, I'll let you continue, I need to work on another project. used git ci -n to skip the pre-commit hooks.

tlogan2000 commented 5 years ago

10-4 merci

From: David Huard notifications@github.com Sent: September-18-19 3:59 PM To: Ouranosinc/xclim xclim@noreply.github.com Cc: Logan, Travis Logan.Travis@ouranos.ca; Assign assign@noreply.github.com Subject: Re: [Ouranosinc/xclim] Fix deprecations in xarray (#270)

Check the PR I just made. WIP, I'll let you continue, I need to work on another project. used git ci -n to skip the pre-commit hooks.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/Ouranosinc/xclim/issues/270?email_source=notifications&email_token=AFLKFOSRLYCW6WB7LH6GO3TQKKB7FA5CNFSM4IWQI5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7BINSY#issuecomment-532842187, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFLKFOWHLO5N2CMVXNUKWS3QKKB7FANCNFSM4IWQI5BA.

huard commented 5 years ago

@tlogan2000 I've added support for lat_bnds=[None, float] but it's untested...

Also need to add a test for curvilinear grids when one of lat_bnds or lon_bnds is None.

Zeitsperre commented 5 years ago

@huard just saw this. In the future, suppress running hooks with git commit --no-verify.

tlogan2000 commented 5 years ago

closed with #274