Ouranosinc / xscen

A climate change scenario-building analysis framework.
https://xscen.readthedocs.io/
Apache License 2.0
15 stars 2 forks source link

Regrid's weights location as kwarg #113

Closed aulemahal closed 1 year ago

aulemahal commented 1 year ago

Pull Request Checklist:

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes, script using positional arguments for this function will break.

Other information:

As a kwarg it can be included in the config, but I may have missed something?

RondeauG commented 1 year ago

Does that still mean that the argument is required? If not, we have to account for cases where is is None.

aulemahal commented 1 year ago

It is still needed, but has to be given as a keyword. In fact, my problem was that I wanted to give it in the config, while giving the datasets positionally. We could also move weights_location before the ,*, and it would then be giveable both ways.

RondeauG commented 1 year ago

I'd go with before the *, then.