add restrict_wl - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

15 stars 2 forks source link

add restrict_wl #138

Closed juliettelavoie closed 1 year ago

juliettelavoie commented 1 year ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #105
[x] (If applicable) Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

new argument to restrict the datasets to only ones that exist in the warming level csv.
subset_warming_level fails if the dataset doesn't exist. Hence, filtering beforehand is necessary.
It is possible to pass a boolean or a dictionnary with arguments similar to subset_warming_level (ignore_member and tas_csv).

Does this PR introduce a breaking change?

no

Other information:

RondeauG commented 1 year ago

I also don't see changes to the documentation? We should add a mention of this in the Catalogs notebook, where we list possible options: https://xscen.readthedocs.io/en/latest/notebooks/1_catalog.html#Advanced-search:-xs.search_data_catalogs