Uniformize environments and update dependencies

aulemahal commented 1 year ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Reorder the environment files to fit what's in setup.py (an alphabetical order)
Remove fixes for esmpy 8.4, as xESMF 0.7 takes care of that (the pin is bumped).
Add a (brand new!) fix for esmpy 8.4 to avoid installing packages with pip with running pip install -e . on xscen
Remove numba for the envs, it is not a direct dep and the bug related to version 0.55 is caduc with 0.56.
Uniformize the two envs : h5netcdf, pyarrow, fsspec

Does this PR introduce a breaking change?

No.

Other information:

This still install netCDF4 1.6.2, I'm not sure if this version has been fixed or not?

aulemahal commented 1 year ago

Well... It works on my machine though...

Zeitsperre commented 1 year ago

Looks like an issue with ESMF?

aulemahal commented 1 year ago

Oh I see, I thought the test failures were because of my PR, but your PRs to main fix them, nice!

The RTD error seems to be related to this issue : conda-forge/esmf-feedstock#91 and the solution is to explicitly activate the env, which I don't think RTD does...

aulemahal commented 1 year ago

Related RTD issue is : readthedocs/readthedocs.org#4067. We will need to patch this environment variable in the code, I'll push something.

Zeitsperre commented 1 year ago

I'm just curious, but is there any way for us to manually restart the environment using the .readthedocs.yml? I.e.:

build:
  jobs:
    pre-build:
      - conda deactivate
      - conda activate xscen-env

aulemahal commented 1 year ago

Well, I thought of that and decided not to do it for 2 reasons:

I didn't want to interfere with RTD's machinery.
Can you call conda activate if you haven't called conda init ? Does RTD call the latter? I'm suspecting it doesn't and this is why the conventional activation mechanism isn't used.

Zeitsperre commented 1 year ago

That makes sense. Was just wondering. Your fix is clear enough for me. :+1:

Ouranosinc / xscen