Closed RondeauG closed 1 year ago
@aulemahal @Zeitsperre Feel free to work directly on this branch and to change/remove what I've done. Once we're happy with the formatting, we'll merge it and I'll start making real unit tests.
What I'm uploading here is a version that uses test_timeseries
and hits pretty much all of climatological_mean
. Since this is the best time to establish a format, I'm open to all suggestions!
Deux questionnements spécifiques:
test_all_default/test_options
est correct ? Est-ce que je devrais les combiner en une seule grosse fonction qui teste à la fois les défauts et options ? Est-ce que je devrais au contraire séparer chaque option dans son propre test ?timeseries
plusieurs fois. Serait-ce mieux de les déclarer au tout début, en variable globale (ou à l'intérieur de TestClimatologicalMean
) ?@RondeauG Please see the changes introduced in my latest commit.
pytest.mark.parametrize
. The benefit here is that if a single element fails:
assert
when we are comparing scalars.set
logic instead of an all
of a in comprehension list.This should be good for review.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
climatological_mean
andcompute_deltas
when using daily data.Does this PR introduce a breaking change?
Other information:
This is a start for #9