[x] This PR addresses an already opened issue (for bug fixes / features)
This PR fixes #xyz
[x] (If applicable) Documentation has been added / updated (for bug fixes / features)
[x] This PR does not seem to break the templates.
[x] HISTORY.rst has been updated (with summary of main changes)
[x] Link to issue (:issue:number) and pull request (:pull:number) has been added
What kind of change does this PR introduce?
Bugfix, especially for compute_deltas. The line deltas = deltas.reindex_like(ds) would create all NaN values if ds was using a CFTimeIndex (such as a 'noleap' calendar) instead of a pandas DatetimeIndex. The same wasn't true for climatological_mean since we don't reindex, but we might as well use the same indexes as the input dataset.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
compute_deltas
. The linedeltas = deltas.reindex_like(ds)
would create all NaN values ifds
was using aCFTimeIndex
(such as a 'noleap' calendar) instead of a pandasDatetimeIndex
. The same wasn't true forclimatological_mean
since we don't reindex, but we might as well use the same indexes as the input dataset.Does this PR introduce a breaking change?
Other information: