Ouranosinc / xscen

A climate change scenario-building analysis framework.
https://xscen.readthedocs.io/
Apache License 2.0
17 stars 2 forks source link

tiny detail in delta attrs #193

Closed juliettelavoie closed 1 year ago

juliettelavoie commented 1 year ago

https://github.com/Ouranosinc/xscen/blob/2f8d143997b00f935590e792b133a0aedce0ce8b/xscen/aggregate.py#L263

This is really a small issue, but in the description and longname of delta, I would prefer a "-", not a "".

RondeauG commented 1 year ago

Sure. I honestly don't remember why we did that. Maybe to separate the periods more clearly?

juliettelavoie commented 1 year ago

I think it might have just been copied from the variable name: var_delta_YYYY_YYYY. We can't have "-" in variable name, but that's not the case for attrs.

RondeauG commented 1 year ago

Fixed by #228.