Ouranosinc / xscen

A climate change scenario-building analysis framework.
https://xscen.readthedocs.io/
Apache License 2.0
15 stars 2 forks source link

Translation #236

Closed aulemahal closed 1 year ago

aulemahal commented 1 year ago

Pull Request Checklist:

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

No

aulemahal commented 1 year ago

https://gist.github.com/aulemahal/415126d7a923f651ad9d8dcf267646bb

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

aulemahal commented 1 year ago

@juliettelavoie I added more details in the documentation!

aulemahal commented 1 year ago

hmmm, @Zeitsperre I might need help here, I don't see why the RTD build is failing... Is it the warning in the linkcheck ? If so, I can't seem to find the warning!

Zeitsperre commented 1 year ago

hmmm, @Zeitsperre I might need help here, I don't see why the RTD build is failing... Is it the warning in the linkcheck ? If so, I can't seem to find the warning!

Looks like it's a reference to a non-existing target:

WARNING: undefined label: 'translating xscen`
Zeitsperre commented 1 year ago

This is a pretty annoying sphinx convention, but thankfully someone on StackExchange has some advice: https://stackoverflow.com/questions/15394347/adding-a-cross-reference-to-a-subheading-or-anchor-in-another-page

aulemahal commented 1 year ago

Thanks!