Fix preprocess logic in to_dataset - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

17 stars 2 forks source link

Fix preprocess logic in to_dataset #246

Closed aulemahal closed 1 year ago

aulemahal commented 1 year ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #245
[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[ ] HISTORY.rst has been updated (with summary of main changes).
- [ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

The passed preprocess function is kept in the kwargs and overridden there if needed.

Does this PR introduce a breaking change?

Other information:

aulemahal commented 1 year ago

Works on my machine.