Closed Zeitsperre closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@aulemahal @juliettelavoie No need to review everything, but I'd like you to look into the Notebooks, at least. I had to change them somewhat because we reduced the size of the underlying datasets.
fake_data
function to fake 70/120 years of climate data after extract_dataset
, for Getting Started and Warming Levels. That means that we can do things properly, but keep the on-disk files at a very small size.pangeo-cmip6.csv
is now the bare minimum (48 lines vs 35000!) to make the Catalogs notebook work.tg_mean
from xclim.testing
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
tests
are not treated as an installable package.tests_require
in thesetup.py
.requires_docs
torequires_netcdf
./docs/notebooks/samples
(from 16Mb to 400kb) and changed the Notebooks and tests to work around it.datablock_3d
moved to a newxscen.testing
xscen.testing.fake_data
to easily populate DataArrays with fake, but realistic data.Does this PR introduce a breaking change?
Sort of.
tests
no longer acts like an installable module. This wil only affect xscen developers who write tests.Other information:
This will be fully obsolete when we move to pyproject.toml, but, for those curious, why not use
tests_require
?