Test search_data_catalogs - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

15 stars 2 forks source link

Test search_data_catalogs #251

Closed RondeauG closed 1 year ago

RondeauG commented 1 year ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[x] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[x] HISTORY.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Tests for search_data_catalogs and its underlying functions.
Added the possibility to search for simulations that reach a given warming level within tas_csv.
Simplified how we created the main catalog, in search_data_catalogs.
Fixed a bug when searching for alternative experiments/members for fixed fields.

Does this PR introduce a breaking change?

No

Other information:

The tests are based on the new catalog files in #248, so we'll either need to merge that one first, or merge this PR into 248.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB