Better spatial mean - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

15 stars 2 forks source link

Better spatial mean #260

Closed aulemahal closed 1 year ago

aulemahal commented 1 year ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #94
[x] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[x] HISTORY.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

One can now pass region='global' to spatial_mean. It will simply be replace by a bbox region covering the whole globe.
spatial_mean, method xesmf will automatically segmentize the polygons down to a resolution of 1°, to ensure a correct average.
Make out_chunks available in regrid_dataset and spatial_mean if using xesmf >= 0.8
Fix spatial_mean with method xesmf and a GeoDataFrame as shape.

Does this PR introduce a breaking change?

Shouldn't.

Other information:

Added a test for region='global'.

aulemahal commented 1 year ago

Exact! Les deux ont un argument "tolerance" dans les mêmes unités que les coordonnées des polygones. Donc des degrés pour tout nos cas. simplify est évidemment un peu plus complexe, y a aussi des tests de validité et autres, mais l'idée c'est en effet l'inverse de segmentize.