Closed aulemahal closed 11 months ago
do we want to add the source to the original data in the csv ? Technically, it is here: https://github.com/Ouranosinc/xscen/blob/b3c79cd02f01c9f791d082459464b0842b5f4f6c/xscen/extract.py#L861C2-L861C2 (not exactly the github page with the data, but the paper links to the repo)
but maybe it needs to be in the csv also? (while we are here anyway)
Good idea!
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Last commits are a rewrite of get_warming_level
and subset_warming_level
so they're easier to use with arrays.
See changes of the warming level notebook for most explanations. And edit on the root comment.
@sarahclaude Should I use this PR to add the global tas average for non-r1i1p1f1 models ? Will you need that ?
I might need it in the future but we are not dealing with warming levels yets, so not on short-term.
PR prête pour la revue.
J'ai laissé faire les membres non-r1i1p1f1 pour le moment. Les modèles ajoutés sont essentiellement ceux qui manquaient de ESPO-G6.
There's output
to potentially remove, but other than that, this looks good to go!
Docs are failing because a file only in this branch isn't present in main. Let me know if you want me to bypass protections to push to main!
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Addition of:
to
xscen/data/IPCC_annual_global_tas.csv
.get_warming_level
, output as those or list.subset_warming_level
.Does this PR introduce a breaking change?
Yes, if
get_warming_level
is called with a sequence of models, the output is now a list of the same length. The dictionary can be retrieved by passingoutput='selected'
. I found it way more useful this way!Other information:
The new global tas were computed with the following code:
See issue #268 for discussion of small differences between this and the official IPCC-provided data.