Ouranosinc / xscen

A climate change scenario-building analysis framework.
https://xscen.readthedocs.io/
Apache License 2.0
15 stars 2 forks source link

Test ESMF from conda and remainder PyPI deps #274

Closed Zeitsperre closed 11 months ago

Zeitsperre commented 11 months ago

Pull Request Checklist:

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

No. ESMF_VERSION is only needed if tox is called with -esmpy flag. The tox config was always dependent on an environment having esmpy, therefore there are few instances where it would work anyway (requires tox-current-env or tox-conda).

Other information:

https://github.com/esmf-org/install-esmf-action (I think I'll wait for the next version before trying this again).

Zeitsperre commented 11 months ago

I have no idea why I keep getting Segfaults on GitHub Actions. There has to be something strange going on with the test setup that isn't memory safe. Is this possible?

aulemahal commented 11 months ago

Can you remind us of what's wrong with installing ESMF through mamba on the CI ?

And why is nc-time-axis a dependency, I don't think we plot anything in xscen ? (I mean outside the docs)

Zeitsperre commented 11 months ago

I'm going to squash these commits to not pollute the history.