add indicators_kw to build_partition_data - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

15 stars 2 forks source link

add indicators_kw to build_partition_data #315

Closed juliettelavoie closed 8 months ago

juliettelavoie commented 8 months ago

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[x] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Add indicators_kw to build_partition_data
I didn't add it at first, because I thought that 1) ideally the input would be indicators already or 2)it could just be done afterwards. However, 1) this is not the data we have now and 2) the data we have is on different calendars so it fails to be in one dataset and calculating the indicators fixes this problem.

Does this PR introduce a breaking change?

No

Other information:

review-notebook-app[bot] commented 8 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB