Fix output chunks in regrid - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

15 stars 2 forks source link

Fix output chunks in regrid #317

Closed aulemahal closed 8 months ago

aulemahal commented 8 months ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[x] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[ ] CHANGES.rst has been updated (with summary of main changes).
- [ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Fix out_chunks to output_chunks in regrid's special argument treatment.
Add tests for regridding.
datablock_3d now returns correct lat/lon for curvilinear coordinates (rotated_pole or oblique_mercator)
Pin pandas <2.2. To be un pinned when xclim 0.48 is released and the frequency codes taken care of.

Does this PR introduce a breaking change?

No.

Other information:

Hmm, no regridder tests... I guess its now my job...

aulemahal commented 8 months ago

Indeed, the other instance was wrong to.