Ouranosinc / xscen

A climate change scenario-building analysis framework.
https://xscen.readthedocs.io/
Apache License 2.0
15 stars 2 forks source link

Make xESMF optional #337

Closed aulemahal closed 7 months ago

aulemahal commented 7 months ago

Pull Request Checklist:

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre I may have been heavy handed in editing the workflow and tox configuration. My idea was that the "test-pypi" didn't need xesmf/esmf anymore and so I removed any mention of it and of mamba/conda. So it can really be a "test-pypi" ci.

aulemahal commented 7 months ago

Yes ça marche!

Issue with Python 3.9 is because of the latest conda package of intake-esm. They dropped 3.9 but the conda recipe didn't know about that.

aulemahal commented 7 months ago

CI fails because the misconfigured conda package still exists in mamba's cache and in the conda-forge repo. But it did pass when I pinned intake-esm.

Coverage for Pypi runs are decreased, which is normal since we don't test any function using xesmf. But the conda converage is stable. @Zeitsperre , what should we do ? Accept the decrease ? Stop reporting coverage for those tests ?

But otherwise, this PR is good to go.

Zeitsperre commented 7 months ago

@Zeitsperre , what should we do ? Accept the decrease ? Stop reporting coverage for those tests ?

I think accepting the one-time decrease is fine. So long as the overall coverage doesn't go down (test-pypi + test-conda), that's what matters.