Add biasadjust tests - Githubissues

Ouranosinc / xscen

A climate change scenario-building analysis framework.

https://xscen.readthedocs.io/

Apache License 2.0

15 stars 2 forks source link

Add biasadjust tests #366

Closed juliettelavoie closed 6 months ago

juliettelavoie commented 6 months ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] This PR does not seem to break the templates.
[x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

add bias adjust tests
fixed a few bugs:
- Removed train from the inside the period for loop. Only need to do it once and bugged with group if inside loop.
- fix _add_preprocessing_attr that was not actually modifying the attrs
- Change way of defining default group

Does this PR introduce a breaking change?

adjust won't fail if dict group and many periods.
preprocessing_attrs will actually be added
If pass group=False, it will actually be False.

Other information:

Is it ok to remove the TODOs ? I'm not sure exactly what they were referring to, I don't think they are relevant anymore.
Should we remove moving_yearly_window I am not actually using the args for info-crue cmip6 and the function has changed name in xclim.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB